more robust table extraction #767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix type check
unsleepy22
force-pushed
the
refine-table-extraction
branch
from
a42df23 to
c510ac5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #767 +/- ##
=======================================
Coverage 99.27% 99.27%
=======================================
Files 21 21
Lines 3576 3587 +11
=======================================
+ Hits 3550 3561 +11
Misses 26 26 ☔ View full report in Codecov by Sentry. |
adbar
reviewed
Dec 18, 2024
adbar
reviewed
Dec 18, 2024
|
@unsleepy22 Thanks for the PR, everything looks OK to me but the code could be improved using the suggestions above. |
Thanks for your comments, updated accordingly, would you take a look again? |
adbar
reviewed
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refine table extraction and add more test cases.